-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most requested: display items in columns #2446
base: master
Are you sure you want to change the base?
Conversation
Pre-approved upon successful review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: see inline.
Note: I reviewed + tested locally and I do confirm the items are re-ordered vertically instead of horizontally.
This change is very perceptible and I do evaluate if as a major change because of the visual change. Additional communication might be required prior to apply this change.
@Ricokola please review and take actions to manage the breaking change. Thanks
@duboisp In my opinion this is more a minor change than a major one. "Minor change: The change are noticeable and complement, add to the user experience and remain at least understandable as it was prior." I don't believe a user would be lost because some items have changed in order. It might be even more understandable for a user now, and easier to comprehend for an author. However, I agree that a communication should be sent to authors so they are aware of the change. We can discuss this further. |
d2df11c
to
756dc12
Compare
This PR changes the distribution of Most requested items from top to bottom and from left to right instead of from left to right and top to bottom.
Before:
1 2
3 4
5 6
After:
1 4
2 5
3 6
Changes related to WET-488